Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release planning (4.2.5) #1740

Closed
2 tasks done
flaeppe opened this issue Sep 27, 2023 · 11 comments · Fixed by #1777
Closed
2 tasks done

Next release planning (4.2.5) #1740

flaeppe opened this issue Sep 27, 2023 · 11 comments · Fixed by #1777
Labels
meta Meta-issues and discussion

Comments

@flaeppe
Copy link
Member

flaeppe commented Sep 27, 2023

TODO:

#1719 introduces plugin support for ManyToManyField but is lacking support for passing AUTH_USER_MODEL as to= arg e.g.:

users = ManyToManyField(settings.AUTH_USER_MODEL)

Which we suspect is a normal use case and should support in any next release.


Please comment on this issue if there's anything else you know should, or want to be included.

@flaeppe flaeppe added the meta Meta-issues and discussion label Sep 27, 2023
@flaeppe flaeppe pinned this issue Sep 27, 2023
@flaeppe
Copy link
Member Author

flaeppe commented Sep 27, 2023

And for anyone feeling adventurous, please try out HEAD on your project(s) and report back here if you run in to anything you think is a new issue. Perhaps we can then resolve it before pushing out a release.

@intgr
Copy link
Collaborator

intgr commented Oct 11, 2023

Now that mypy 1.6.0 is out, we should consider making a release with the compatible-mypy bump. I can do the release.

I'd consider this a blocker, since it's a regression and we already have a fix PR:

@intgr
Copy link
Collaborator

intgr commented Oct 12, 2023

I'm releasing djangorestframework-stubs too, any takers to review this for the release:

@flaeppe
Copy link
Member Author

flaeppe commented Oct 12, 2023

It'd be nice if we could also include #1767 in the next release

@intgr
Copy link
Collaborator

intgr commented Oct 13, 2023

I want to move forward with:

Making no changes quite yet, but I propose mentioning in 4.2.5 release notes that the next next version (4.2.6) will remove hard mypy dependency. Something like:

(outdated text)

django-stubs is taking steps to improve experience with other type checkers besides mypy. Next version (4.2.6) will remove explicit mypy dependency. If you are currently using mypy, please add an explicit dev dependency on mypy to your project, or depend on django-stubs with the compatble-mypy extra, e.g. django-stubs[compatible-mypy].
Note: this is not a guarantee that other type checkers will be fully supported, pull requests for improvements are welcome. See #1628 for details.

If you have comments on this, please discuss in #1628.

@flaeppe
Copy link
Member Author

flaeppe commented Oct 18, 2023

We could always push another release if we want to. If you feel that one is due

@sobolevn
Copy link
Member

I think property stuff can wait, really.

@intgr
Copy link
Collaborator

intgr commented Oct 18, 2023

It's out!

@intgr
Copy link
Collaborator

intgr commented Oct 18, 2023

And also djangorestframework-stubs 3.14.4

@intgr
Copy link
Collaborator

intgr commented Oct 19, 2023

I introduced some issues in #1724 that will be fixed by #1778.

I will wait a few days to see if other bug reports come in and make a follow-up release soon. Opened release planning issue: #1780

@flaeppe flaeppe unpinned this issue Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Meta-issues and discussion
Development

Successfully merging a pull request may close this issue.

3 participants