Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

submit Priority to scala.util.Priority? #67

Open
johnynek opened this issue Jul 7, 2015 · 5 comments
Open

submit Priority to scala.util.Priority? #67

johnynek opened this issue Jul 7, 2015 · 5 comments

Comments

@johnynek
Copy link
Contributor

johnynek commented Jul 7, 2015

I copied https://github.com/non/algebra/blob/master/core/src/main/scala/algebra/Priority.scala into algebird because I wanted to resolve an issue with algebird + spark and spark's approach of using implicit ord: Ordering[K] = null with the fact that you can't in 2.11 have overloaded methods and default parameters (so I used Priority[Ordering[K], DummyImplicit] and .getPreferred.orNull).

It occurs to me, this could be a candidate to add to scala. It is unlikely to change much.

If they'd never accept it, no big deal, but it seems to be one of the easier things to move there.

@non
Copy link
Contributor

non commented Jul 7, 2015

Sure, let's give it a shot! Do you want to submit it or shall I?

@johnynek
Copy link
Contributor Author

johnynek commented Jul 7, 2015

Either way. If you want to, you are more than welcome, but similarly, I don't want to task you. I'm willing to as well (of course as is often the case, I might be slow to get to it).

@non
Copy link
Contributor

non commented Jul 7, 2015

Why don't you do it? If you decide you don't have time comment here and then I'll do it if/when I get to it. :)

@johnynek
Copy link
Contributor Author

johnynek commented Jul 8, 2015

sounds good.

@johnynek
Copy link
Contributor Author

I guess this fell off my radar. :(

I think the better approach might be to actually just use Either in the standard library, especially since right biased map has been standardized.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants