Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Traverse mixin on Validated instances #1553

Closed
leandrob13 opened this issue Mar 9, 2017 · 2 comments
Closed

Separate Traverse mixin on Validated instances #1553

leandrob13 opened this issue Mar 9, 2017 · 2 comments

Comments

@leandrob13
Copy link
Contributor

The Traverse mixin with ApplicativeError adds a unnecessary Semigroup restriction to the Invalid side. This issue will be solved on #1548

implicit def catsDataInstancesForValidated[E](implicit E: Semigroup[E]): Traverse[Validated[E, ?]] with ApplicativeError[Validated[E, ?], E] =
    new Traverse[Validated[E, ?]] with ApplicativeError[Validated[E, ?], E]
@leandrob13 leandrob13 mentioned this issue Mar 9, 2017
Merged
@ceedubs
Copy link
Contributor

ceedubs commented Apr 17, 2017

#1548 was merged. Is this now resolved?

@ceedubs
Copy link
Contributor

ceedubs commented Jun 1, 2017

It looks to me like this was solved by #1548, so I'm going to go ahead and close it out. @leandrob13 please open this back up and let me know if I'm mistaken.

@ceedubs ceedubs closed this as completed Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ceedubs @leandrob13