-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cats 1.0.0 packaging #1682
Comments
My vote |
|
My final vote |
Only strong opinions are on 2 and 3. On 2, I strongly oppose moving alleycats into the cats repo. Polyrepo is significantly easier to manage here, and it ensures that the versioning is kept independent. Having things like alleycats, dogs, cats-mtl and cats-effect in repos that are separate from cats-core is a major win relative to the way that scalaz is setup, since scalaz's versioning is fundamentally tied together, meaning that changes which are non-breaking for core still have to increment the core breaking version, which in turn cascades through the entire ecosystem. Regarding 3, option c seems fine, but I'm ok with any which publishes the test infrastructure. |
|
|
Results (if a vote for (
I think for 1.0.0-MF, we just do
|
This is an issue consolidating all the packaging/publish related issues #1656, #1184, #472 and #592.
There are three separate decisions that are sort of related. It may make sense to decide on all of them all together. Here is the revised version of @BennyHill's summarization in this comment (I added more description for context)
The cats-laws includes a scalacheck dependency which surprises people.
Options are:
a) Keep as-is
b) Keep as-is but minus test libs
c) Rename as-is
d) Rename as-is but minus test libs
e) Remove
Options are:
a) Keep as-is, i.e. separate repo
b) move in as cats submodule. It will keep using a separate top
alleycats
namespace and will not be included in the cats bundle shall we decide to keep one. As a submodule, its releases will be part of cats release, but unlike cats-core, it is allowed to have binary breaking changes between patch versions for alley-cats, at least for now, since it's API hasn't reached the stable status yet.a) Create a new module called
cats-testkit
that includes the following utils fromcats-tests
: Helpers,CatsSuite and CatsEquality
Note that these classes are not required for users to write cats style tests -
cats-laws/discipline
is the one that is required.cats-testkit
will depend oncats-laws
b) keep as-is
c) simply publish
cats-tests
( but not included in the cats bundle shall we have one. )We've done extensive discussion around these for quite a while. So I propose we are ready to collect votes and see if we can reach consensus.
The text was updated successfully, but these errors were encountered: