-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FiniteDuration instances #2517
Comments
I will do it :) |
Awesome, thank you @satansk. |
I use |
@satansk If you're still working on this feel free to keep going :) Can we just reuse https://github.com/typelevel/cats/blob/master/kernel/src/main/scala/cats/kernel/instances/duration.scala With Where do these instances go? @codecentric Thanks! |
Yes the instances should be exactly the same :) and you should be able to place them analogously to where the duration instances are placed |
I opened a PR here, @satansk if you wanted to work on this i'm more than happy to close it! |
@calvinbrown085 go ahead :) I'm busy for a release in company, and I was planning to work on this on my 7 days vocation one day later. Since you already have made a PR, just keep on working on it. |
@satansk Sounds good! Just making sure I don't trample on anyone :) |
We currently have instances for
Duration
only, which means that you can useFiniteDuration
with it, but must upcast it, which can be annoying:The text was updated successfully, but these errors were encountered: