-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate should validate Scaladocs too #516
Comments
@non I'm unable to reproduce this. Do you have an example of a change that should cause it to fail but doesn't? It includes a |
In the |
Ah, I suspect this and #510 have the same root cause. |
I think I see the issue. PR incoming. |
Hmm. I thought it was as easy as adding the laws project to https://github.com/non/cats/blob/672e0105f2d0136c3185ff79300a002384a2ec8b/build.sbt#L58 but I get some bizarre errors if I try to do that. I'm not sure what is going on. |
Ohhhh, now I'm almost remembering something. I think maybe we hit these errors a long time ago and disabled the laws project because we didn't understand them. I also wonder if any of this is related to #510. |
Investigated this for a little. After making the change outlined @ceedubs the doc build starts to fail. Some observations:
Interestingly,
There is something peculiar about the specific syntax for these two type classes that when compiled in this specific context, the compilation is failing. There may be other things at play here, and the path may end up being a dead end, but wanted to record this anyway in case it triggers any thoughts for anyone else. |
I think that this is due to #510, so I'm going to close it out as a duplicate of that. |
Right now it's possible to have Scaladoc errors which aren't caught by
validate
.We should have it run
compile:doc
(or similar) for each project in addition to the other work it is doing.The text was updated successfully, but these errors were encountered: