Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Strong/Weak Laws for MonadFilter/MonadCombine #694

Closed
mikejcurry opened this issue Nov 22, 2015 · 2 comments
Closed

Separate Strong/Weak Laws for MonadFilter/MonadCombine #694

mikejcurry opened this issue Nov 22, 2015 · 2 comments
Labels
Blocked scope: medium Source Breaking

Comments

@mikejcurry
Copy link
Contributor

#693 and #687 refer to Strong and Weak Laws for MonadFilter/MonadCombine. In #687 the MonadCombine instance for XorT was commented out as it was unused. It was unused due to the fact that the MonadCombine instance for XorT could not meet some of the laws for MonadFilter, namely: right absorbtion, right distributivity, and left distributivity. #693 will make a similar change for OptionT and reduce the available instance from MonadCombine to Monad.

It is suggested that these need to be separated out into Weak and Strong Laws, at which point an instance, supporting the appropriate weaker laws, can be reinstated for both XorT and OptionT.
This was referenced Nov 22, 2015
Open
Merged
@travisbrown travisbrown mentioned this issue Apr 5, 2016
Closed
5 tasks
@ceedubs ceedubs mentioned this issue Apr 18, 2016
Closed
@peterneyens peterneyens mentioned this issue Jun 14, 2016
Closed
@adelbertc adelbertc added this to the cats-1.0.0 milestone Jun 14, 2016
@kailuowang kailuowang assigned kailuowang and unassigned kailuowang Apr 10, 2017
@kailuowang
Copy link
Contributor

Some of the problematic laws are in AlternativeLaws, which is part of the #1210 refactor. Hence, blocked by #1210

@kailuowang
Copy link
Contributor

No longer needed due to #1616, moved out of the 1.0.0-MF, will close once mtl removal plan is completed.

@kailuowang kailuowang removed this from the 1.0.0-MF milestone May 31, 2017
@LukaJCB LukaJCB closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocked scope: medium Source Breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kailuowang @adelbertc @LukaJCB @mikejcurry