-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release scalacheck_sjs0.6_2.13.0-M1 #330
Comments
ping |
This is actually holding up a good chunk of the ecosystem, since most projects cannot release their SJS 2.13.0-M1 cross-builds without ScalaCheck and ScalaTest. |
The
|
Ping @sjrd. |
just remove https://github.com/rickynils/scalacheck/blob/1.13.5/build.sbt#L51 |
That's an option: https://github.com/djspiewak/scalacheck/tree/wip/2.13 It'll have to be addressed eventually though. |
http://www.scala-js.org/news/2017/03/21/announcing-scalajs-0.6.15/ explains the deprecation and how to migrate |
As pointed by @SethTisue, the 0.6.15 release notes should explain everything you need to know to migrate. Feel free to ask further questions if it's not enough. There's even a "Are you maintaining a testing framework?" section, just for you guys :P |
@rickynils is your wip on this on GitHub? I could try to finish it up. |
@SethTisue No wip. I just bumbed the scalajs version in plugins.sbt. If PRs are provided for the 1.13.5_sonatype and 1.12.6_sonatype branches I can try to publish releases. But maybe we have to cut new releases if there are code changes. Sorry for my unresponsiveness. It is mainly because I got a kid some weeks ago, and partly because I have never used ScalaJS. |
please continue to prioritize your human children over your digital ones :-) the release notes say that |
hmm, actually it's not that hard to go ahead and make the necessary changes to not use the deprecated stuff at all. revising the PRs now |
hmm, well, probably better to make the minimal change on the release branches. I did the better version on master (#341); the other two are fine as-is I think. |
@SethTisue Thanks for the PRs! I've published releases for ScalaCheck 1.12.6 and 1.13.5 |
@rickynils
The text was updated successfully, but these errors were encountered: