Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiloyards Length UnitOfMeasure Support #298

Open
ALPSMAC opened this issue Feb 15, 2018 · 1 comment
Open

Kiloyards Length UnitOfMeasure Support #298

ALPSMAC opened this issue Feb 15, 2018 · 1 comment

Comments

@ALPSMAC
Copy link

ALPSMAC commented Feb 15, 2018

As odd of a unit of measure as it is, my office actually has need of Kiloyards as a unit of measure quite regularly. I imagine this is just as simple as adding it into the existing units of measure defined for squants.space.Length, correct?

Or for strange units of measure like this one would we prefer to keep them defined as a ratio instead of directly inside Length?

More generally - is there a defined way to add additional UnitsOfMeasure over an existing abstract type (i.e. Length) without having to directly manipulate the library itself? It would be nice to have the ability to extend Squants with custom UnitsOfMeasure and it looks like perhaps there's been some work in that direction but I'm not sure what the guidance is there in general.

Reference:
https://www.convertunits.com/info/kiloyard
https://www.convertunits.com/info/kilofoot

See PR #297

@hunterpayne
Copy link
Contributor

hunterpayne commented Jan 21, 2019

I'm glad you got your change merged. You can go ahead and close this issue I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants