Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requests to EXTERNAL_REQ_ALLOWLIST #131

Closed
kasium opened this issue Mar 25, 2024 · 2 comments
Closed

Add requests to EXTERNAL_REQ_ALLOWLIST #131

kasium opened this issue Mar 25, 2024 · 2 comments

Comments

@kasium
Copy link

kasium commented Mar 25, 2024

Coming from #90 it would be great to add requests to this list since it's needed to properly the recently added stubs for hvac. I guess it's a quite safe library to add (very common, no big dependencies beside urllib3, secure, ...)

@AlexWaygood
Copy link
Contributor

AlexWaygood commented Mar 25, 2024

requests doesn't ship with a py.typed file, so there wouldn't be much use adding it as a dependency for a stubs package. Can't you just add a dependency on types-requests instead (the stubs package typeshed distributes for requests)? Several of our other typeshed packages already do, e.g. https://github.com/python/typeshed/blob/db8e620e3db6eee13f70fbb6cfc90a851e4260c1/stubs/requests-oauthlib/METADATA.toml#L3

@kasium
Copy link
Author

kasium commented Mar 25, 2024

Valid point 😄

@kasium kasium closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants