Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability at js-yaml #471

Closed
highfivedenis opened this issue Mar 22, 2019 · 3 comments
Closed

Security vulnerability at js-yaml #471

highfivedenis opened this issue Mar 22, 2019 · 3 comments

Comments

@highfivedenis
Copy link

@commitlint/load uses a vulnerable version of cosmicconfig and tslint (which uses a vulnerable version of js-yml), see https://nodesecurity.io/advisories/788 for more details on the security issue.
js-yml 3.13.0 is patched, but cosmicconfig and tslint has yet to update its version.

yarn audit output:

┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Denial of Service                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ js-yaml                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ cosmiconfig                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ cosmiconfig > js-yaml                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/788                       │
└───────────────┴──────────────────────────────────────────────────────────────┘


┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Denial of Service                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ js-yaml                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ tslint                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ tslint > js-yaml                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/788                       │
└───────────────┴──────────────────────────────────────────────────────────────┘

Expected Behavior

Use a patched version of cosmicconfig and tslint when it's available, see this cosmicconfig issue & pr and this tslint issue

Current Behavior

Uses a vulnerable version of cosmiconfig and tslint

@agrohs
Copy link

agrohs commented Apr 9, 2019

cosmiconfig seems to have upgraded to js-yml 3.13.0 in 5.2.0.

@ghost
Copy link

ghost commented Apr 17, 2019

High Code injection
Package js-yaml
Dependency of husky
Path husky > cosmiconfig > js-yaml
More info https://npmjs.com/advisories/813

@typicode
Copy link
Owner

Thanks for letting me know. All dependencies have been updated in v2.0.0, there shouldn't be warnings anymore 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants