husky package post install hook fails on windows

[capaj]

> [email protected] postinstall C:\Users\jspac001\repos\ProductivityHubUI\node_modules\husky
> opencollective-postinstall || true

'opencollective-postinstall' is not recognized as an internal or external command,
operable program or batch file.
'true' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] postinstall: `opencollective-postinstall || true`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

is what happens on a windows machine.

[typicode]

Thanks for the report. I'm not sure why it can't find open-collective. It's defined as a dependency and I've just tried on Windows.

Could you try with a freshly created repo?

git init
npm init -y
npm install husky --save-dev

[emily-curry]

@typicode I'm experiencing this occasionally in a CI environment, where the environment has kept the node modules from the previous installation but the husky version has changed so it's updating.
Clean installs always work fine, but unfortunately this CI environment is out of my control. On windows, there's no true, though. Looking at other popular packages, I believe || exit 0 is a more reliable way to handle this (1, 2), although core-js uses || echo \"ignore\" which is probably reliable as well.

[capaj]

I confirm that clean installs run fine.

[typicode]

@emily-curry thanks a lot for checking the other projects, do you want to make a PR with || exit 0?

[naingaungphyo]

Now latest(master) core-js code changed from

|| operator

to

"postinstall": "node -e "try{require('./postinstall')}catch(e){}"".

in package.json

Husky postinstall script should be changed into the same way, because it is causing error in powershell.
The error is the same as this core-js issue