Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversations pagination and missing title/subject #51

Open
ghost opened this issue May 12, 2016 · 3 comments
Open

Conversations pagination and missing title/subject #51

ghost opened this issue May 12, 2016 · 3 comments
Milestone

Comments

@ghost
Copy link

ghost commented May 12, 2016

Maybe I have missed this. There is no way to paginate the conversations; supposing a user has 100 conversations it is not safe to return all conversations.

Conventionally messages/threads/conversations require a title. There is no field a conversation title in the conversations table.

@ghost
Copy link
Author

ghost commented May 12, 2016

I see the pagination issue has been touched in a previous thread. I have looked at the code. Isn't it much better to use Eloquent queries or query builder for Laravel in EloquentTBMsgRepository.php ? The Eloquent model already has a pagination system.

@tzookb
Copy link
Owner

tzookb commented May 12, 2016

Yes I know, for sure.
I'm currently working on version 3, that will have pagination and conversation titles :)

It is quite close to finishing.
Just need to add more stuff and clean.

You can check branch"v3"

@ghost
Copy link
Author

ghost commented May 12, 2016

Great! Thanks.

I will check it.

@tzookb tzookb added this to the version3 milestone May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant