Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosparam vs. topics in uArm_core #9

Open
jetdillo opened this issue Mar 6, 2017 · 1 comment
Open

rosparam vs. topics in uArm_core #9

jetdillo opened this issue Mar 6, 2017 · 1 comment

Comments

@jetdillo
Copy link

jetdillo commented Mar 6, 2017

Hi, looking through the code, uarm_core.py in particular, I see a lot of use of the parameter server to store the angles and positions of the servos on the arm. These are then accessed by the report_* scripts which then publish the same position and angle data out to the appropriate topics.
Normally, the parameter server is used for getting/setting command-line options and passing parameters into a launch file. I'm curious why you're using it this way rather than publishing straight to the relevant topics from within uarm_core.py.

Also, please consider removing the interactive functionality in the various scripts. It makes it difficult to start them as part of a launch file.
Thanks!

@realcx
Copy link

realcx commented Mar 10, 2017

Hi jetdillo,
Thanks for your time and suggestion! What you suggested is rational We will update the ros code later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants