Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Consider forcing a reload of the extension when filters have to be reloaded #22

Closed
gorhill opened this issue Jun 27, 2014 · 5 comments
Closed

Comments

@gorhill
Copy link
Contributor

gorhill commented Jun 27, 2014

I have noticed that whenever filters have to be reloaded, the memory footprint baseline of uBlock ever inches up. There is no memory leaks, it's just that it seems when temporarily handling MB of data (filter loading/parsing), the browser seems to keep stuff around and this is out of control of the extension. HTTPSB suffers the same problem, and as far as I can tell, other extensions too.

Since in uBlock nothing is temporary (as opposed to HTTPSB), when filters need reloading, simply force a reload of the extension, this way a new background page is created, all clean and tidy.

@gorhill
Copy link
Contributor Author

gorhill commented Jul 26, 2014

Need to look into this more, to find out whatever can mitigate the memory footprint climbing when all filters are reloading. Somehow it appears a lot of stuff are stuck in chromium's GC tree. Restarting the extension would probably solve this, but this has the annoying (I suppose) side effect of the extension's tab being closed. Advantage: very simple to implement, I could just add another apply button named Apply changes and restart.

@ghost
Copy link

ghost commented Jul 26, 2014

This would be great indeed.

@kikaxa
Copy link

kikaxa commented Jul 27, 2014

side effect of the extension's tab being closed

Then reopen it after reload? One more permission, though.

@gorhill
Copy link
Contributor Author

gorhill commented Sep 14, 2014

With ee81436#diff-6, it is now an even more attractive idea, had the net filters with a visible counterparts can be applied on already opened web pages when uBlock is launched.

The best time to re-launch would be after a selfie has been generated.

@gorhill
Copy link
Contributor Author

gorhill commented Feb 24, 2015

Idea discarded.

@gorhill gorhill closed this as completed Feb 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants