Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkbucks.com #255

Closed
smed79 opened this issue Jan 1, 2017 · 9 comments
Closed

linkbucks.com #255

smed79 opened this issue Jan 1, 2017 · 9 comments

Comments

@smed79
Copy link
Contributor

smed79 commented Jan 1, 2017

URL(s) where the issue occurs

http://www.linkbucks.com/AYNZ
http://www.zytpirwai.net/AYNZ

Describe the issue

Unblocked popups.

Versions

  • Browser/version:

http://i.imgur.com/xmXSoZ2.png

  • uBlock Origin version:

http://i.imgur.com/okaHmSt.png

Settings

http://i.imgur.com/65yZT6p.png

http://i.imgur.com/27IyofE.png

Screenshot(s)

http://i.imgur.com/UeNZcAC.png

@gorhill
Copy link
Member

gorhill commented Jan 1, 2017

I could reproduce.

@ghajini
Copy link
Collaborator

ghajini commented Jan 1, 2017

could reproduce popups plus some malware redirects and trojans

[gorhill: Please refrain from adding noise to this issue]

@ghajini
Copy link
Collaborator

ghajini commented Jan 1, 2017

sorry for that....but i am really got infected...

@gorhill
Copy link
Member

gorhill commented Jan 1, 2017

Report to malware list maintainers whatever site you think infected you.

@gorhill
Copy link
Member

gorhill commented Jan 1, 2017

The site opens a first popup about:blank, then opens a second popup through that first one (see code excerpt below), then closes the first one. The closing of the first popup by the site itself causes uBO to fail to find the tab which opened the second popup (which contains the nasty ads) -- and thus the popup filtering code fails to execute for that second popup.

var ghost = window.open('about:blank');
ghost.open(url, generateName(), windowConfig);
setTimeout(function () {
    ghost.focus();
    ghost.close();
}, 100);

@gorhill
Copy link
Member

gorhill commented Jan 1, 2017

I have two flavors of a fix:

  1. Both popups are closed (including the about:blank one).
  2. Only non-about:blank popups are closed.

I checked with FF+ABP, and the behavior is solution 2. @smed79, do you know if this is the intended behavior from ABP or if this should be considered an issue given the filter *$popup? (I went through ABP issue tracker and couldn't find anything about about:blank popups not being closed).

@smed79
Copy link
Contributor Author

smed79 commented Jan 1, 2017

Sorry i have no idea.

@Betsy25
Copy link

Betsy25 commented Jan 2, 2017

Just FYI, there are a lot of site specific "solutions" at github.com/adsbypasser/adsbypasser

@ghost
Copy link

ghost commented Jan 2, 2017

Hey, which OS you are using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants