-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uBo lite detected on megaup.net #15
Comments
I see two filters enforced in uBO's logger for that site which can't be directly converted to MV3:
First one might be converted to a Solution is to use uBO, I can't make the regex work in uBOL, it's an MV3 API limitation. |
Thanks for creating the mv3 hardship label, @gorhill. I'm hoping this label will help inform discussions at the WECG and in Chrome. AFAIK the regular expression doesn't work in MV3 because Chrome uses RE2 for dNR regular expression matching and RE2 doesn't support lookarounds. I think that if |
That part is important as it prevent false positives, and also it's not so sure it would still work in uBOL, consider these regexes which are currently rejected by DNR:
It's just a sample, I currently see 39 regexes (out of 136 total) with no lookaround part in default filterset which are refused by the DNR API because of |
Thanks for the clarification. The memory limit for compiled RE2 expressions slipped my mind. I feel like it should be possible to rewrite that expression to avoid lookarounds (and am trying hard not nerdsnipe myself with this), the compiled expression may be too large for dNR's current limits. @gorhill, if it's not too much trouble, would it be possible to get a gist/paste/whatever with those 39 rules? I think dNR rules would be best, but even just the list of RegExps would be quite helpful. |
@dotproto you can take a look here: https://github.com/gorhill/uBlock/blob/master/dist/mv3/log.txt searching for and as I posted on slack the issues list here: |
The rejected regexes are reported at the dev tools console of uBO Lite when installing or reloading the extension. I am not at the desktop computer at the moment. @dotproto Here are the regexes currently rejected by the DNR engine at runtime -- none of these have lookaround part since such regex filters are discarded at compile time:
|
Sorry, how can I see this? I don't see anything on Console of background or dashbord when I refresh the page or disable-enable uBOL. |
You need to install uBOL as a local package. Download from releases. For chromium, unzip then load with "Load unpacked". For Firefox go to |
Prerequisites
I tried to reproduce the issue when...
URL(s) where the issue occurs
https://megaup.net/1aknk/sc23898-TSOMISE.rar
Describe the issue
uBlock is detected when loading megaup.net pages with optimal or complete settings.
when using basic setting uBlock is not detected and some ads are blocked, but I still see many ads that are not blocked.
Screenshot(s)
basic is not detected but many ads are not blocked
optimal and complete is detected:
uBlock Origin version
uBlock Origin Lite 0.1.22.11165
Browser name and version
Edge Version 107.0.1418.62 (Official build) (64-bit)
Settings
Notes
No response
The text was updated successfully, but these errors were encountered: