-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display numbers are not correct in popup menu (NL) #2364
Comments
https://en.wikipedia.org/wiki/Mega- ? Should be handled by browser, but maybe it's not? #1027 (comment) |
In Microsoft Edge browser this is not a problem. I found the problem.In the issue tracker I wrote that you have to check the box I unchecked this box and added "Nederlands" (Dutch) to the list. After I did this the handling of the number was correct (3,592 milj. instead of the 3.592M) For me this is really strange as uBlock should not look for the language set at
|
This will require "you" to generate several XPI files and generate several new URLs due addons store no offer division due to language, but only a separate XPI for Android (The Dutch description uses same XPI as in the English/US version). Maybe exist short JavaScript workaround to update read preferences from only browser instead from webpages. Chromium maybe allow spy system language so pointless is change this into browser. Chrome Web Store also not offer different crx if use |
Can be related: w3c/webextensions#258 |
I am unable to remove the English US entry, the browser does not allow me to do so.
I don't see a checkbox got this. Ok I can now reproduce, I replaced the step "check the box ..." with just promoting (moving up) English as the language to use to download webpages. Now I have Dutch text but English number format. |
Maybe because your browser language is already set to English this checkbox does not appear.
👍 |
Actually I can't reproduce. It looks like I would have to download and install the Dutch package of Firefox. |
I have the Dutch package.
Edit:It is noteworthy that this problem does NOT occur if the English Language Package is installed. This means, that this issue - as far as I know - This also applies if you install the French or German Language Package for Firefox, but you leave the |
Is it still an issue? I tried reproducing as described above and I can't. |
Yes, but it has to do with the fact that have my Firefox browser language in Dutch, but also enabled the function that Firefox should sent to every page that my language is English. (As you can see in the images in my issue description.) |
After I set Firefox to receive English pages, my popup panel was still respecting the language set for Firefox UI (French), so I guess I just don't get what is the issue. |
That's correct.
Make sure will doing each step to disable and then enable uBlock again to activate the changes in the popup. |
As far as French/Canadian notation differs from English. |
Restarted Firefox. Result: Firefox UI is French, uBO's popup panel respects French notation (thin space separating thousands instead of |
In French the notation is |
Did you also disable and then re-enable ublock? |
Yes. Tested on Firefox 111.0. Your Firefox looks very different than mine, what version are you using? Maybe try in a new profile, if you modified stuff in |
I did change a lot. But that has to do with the looks. I'm using https://github.com/BPower0036/UserChrome/tree/main/FireFox. |
On GNU/Linux maybe hard be found correct path. |
Although closed as invalid. I can report now that due to changes in Firefox this problem is solved. |
Prerequisites
I tried to reproduce the issue when...
Description
I am using Firefox version 107.0
In the settings of FF I set the language of my browser to Dutch.
Also I downloaded the Dutch version of uBlock.
As you can see in the screenshot below, the text of the popup is in Dutch.
However, the number counting (blocked since installation) does not follow the Dutch system, but the English/American.
This should not be the case.
Screenshots
A specific URL where the issue occurs.
popup menu
Steps to Reproduce
about:preferences
to Dutch -- remove alternatives if there are any.Choosing your preferred languages to display web pages
andcheck the box Request English-language versions of web pages for enhanced privacy / Engelstalige versies van webpagina’s opvragen voor verbeterde privacy.
https://addons.mozilla.org/nl/firefox/addon/ublock-origin/
(the Dutch version of FF Add-ons)and download uBlock.
Expected behavior
I expect the counting and display of numbers in the popup follows the language of the downloaded uBlock version.
So, if I install the uBlock from the Dutch version of Firefox Add-ons / AMO not only the language should be Dutch but also the way numbers are displayed in the popup.
Actual behavior
Language of popup is Dutch, but the way the numbers are displayed is in the English/American style (and not the Dutch system).
Configuration
The text was updated successfully, but these errors were encountered: