Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cause memory leak on Firefox 107 #2401

Closed
8 tasks done
psydvl opened this issue Dec 10, 2022 · 3 comments
Closed
8 tasks done

Cause memory leak on Firefox 107 #2401

psydvl opened this issue Dec 10, 2022 · 3 comments
Labels
invalid not a uBlock issue

Comments

@psydvl
Copy link

psydvl commented Dec 10, 2022

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

uBlockOrigin cause memory leak on Firefox

Related data:

Firefox Profiler
https://share.firefox.dev/3W1GKDj

Shell comands output

$ free # about 8gb ram + 8gb swap
               total        used        free      shared  buff/cache   available
Mem:         7861296     4533736      386624      856640     4105312     3327560
Swap:        8388604      461056     7927548
$  # before 610 MB or 2,4 GB virtual
$ PD=10931 && ps -O sz,vsz -wwp $PD && echo && ps -Fwwp $PD
  PID    SZ    VSZ S TTY          TIME COMMAND
10931 609796 2439184 S pts/3  00:00:00 /usr/lib64/firefox/firefox -contentproc -childID 2 -isForBrowser -prefsLen 31103 -prefMapSize 226290 -jsInitLen 246704 -parentBuildID 20221128144904 -appDir /usr/lib64/firefox/browser {ad28b4ac-3710-4f6f-8cc1-2d0ac79aafbf} 10768 true tab

UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
nixi     10931 10768  0 609796 122804 2 04:35 pts/3    00:00:00 /usr/lib64/firefox/firefox -contentproc -childID 2 -isForBrowser -prefsLen 31103 -prefMapSize 226290 -jsInitLen 246704 -parentBuildID 20221128144904 -appDir /usr/lib64/firefox/browser {ad28b4ac-3710-4f6f-8cc1-2d0ac79aafbf} 10768 true tab

$  # after: 4,8GB or 19GB virtual
$ PD=10931 && ps -O sz,vsz -wwp $PD && echo && ps -Fwwp $PD
  PID    SZ    VSZ S TTY          TIME COMMAND
10931 4868825 19475300 S pts/3 00:00:03 /usr/lib64/firefox/firefox -contentproc -childID 2 -isForBrowser -prefsLen 31103 -prefMapSize 226290 -jsInitLen 246704 -parentBuildID 20221128144904 -appDir /usr/lib64/firefox/browser {ad28b4ac-3710-4f6f-8cc1-2d0ac79aafbf} 10768 true tab

UID        PID  PPID  C    SZ   RSS PSR STIME TTY          TIME CMD
nixi     10931 10768  0 4868825 171276 3 04:35 pts/3   00:00:03 /usr/lib64/firefox/firefox -contentproc -childID 2 -isForBrowser -prefsLen 31103 -prefMapSize 226290 -jsInitLen 246704 -parentBuildID 20221128144904 -appDir /usr/lib64/firefox/browser {ad28b4ac-3710-4f6f-8cc1-2d0ac79aafbf} 10768 true tab

A specific URL where the issue occurs.

http://x.com

Steps to Reproduce

  1. Open fresh Firefox profile
  2. Install uBlockOrigin
  3. Watch memory usage

Expected behavior

About few more MB requested

Actual behavior

15(?) GB memory requested, more than I even have

uBO version

1.45.2

Browser name and version

Firefox 107.0.1 (64-bit)

Operating System and version

openSUSE Tumbleweed 20221208-0

@psydvl
Copy link
Author

psydvl commented Dec 10, 2022

Memory reports (from about:memory)
Use verbose check with Load and diff button
memory-report_before.json.gz
memory-report_after.json.gz

@gorhill
Copy link
Member

gorhill commented Dec 10, 2022

I don't see any undue memory usage in your memory-report_after, and certainly not "15(?) GB requested".

Maybe your are confusing memory usage with memory addressing usage, which is virtual memory, not physical memory. Using WASM causes higher virtual memory usage, which is not memory leak.

@gorhill gorhill closed this as completed Dec 10, 2022
@gorhill gorhill added the invalid not a uBlock issue label Dec 10, 2022
@krystian3w
Copy link

In addition, tomorrow is expected to be the release of stable version 108, maybe by Friday also in the repository of openSUSE.

@garry-ut99 garry-ut99 mentioned this issue Apr 8, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

3 participants