Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic filtering: add option for strict partyness #2912

Closed
9 tasks done
user31415192 opened this issue Oct 29, 2023 · 3 comments
Closed
9 tasks done

Dynamic filtering: add option for strict partyness #2912

user31415192 opened this issue Oct 29, 2023 · 3 comments
Labels
declined declined

Comments

@user31415192
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT an issue with YouTube, Facebook or Twitch.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

I want it so that uBO has an option for a dynamic filter to not propagate to subdomains.
My proposed dynamic filter syntax:

source dest ssp sdp type action

Where:
source and dest: Source and destination hostname, respectively. Subpaths are also supported, for example: example.com/rsrc/foo.
ssp: Strict Source Partyness: Whether to prevent dynamic filter from propagating to subdomains of the source hostname.
Possible values:

0 (default value): dynamic filter will propagate to subdomains of the source hostname as usual.
1: dynamic filter shall not propagate to subdomains of the source hostname.

Please note that this value matters not when the value of the source component is *. In such a case, a value of 0 for ssp is preferred.

sdp: Strict Destination Partyness: Whether to prevent dynamic filter from propagating to subdomains of the destination hostname. Same as above.
type: Type of resource to filter. Use values supported in Dynamic URL filtering.
action: What to do with requests matching all the above conditions. Such requests can be block-ed, allow-ed, or let static filtering make the decision instead (noop).

As usual, more specific rules override less specific ones.

Examples:
deviantart.com * 0 0 script block
Meaning: disable all scripting on deviantart.com and all its subdomains.

www.msn.com/en-us acdn.adnxs.com 1 1 * noop
Meaning: requests whose origin matches www.msn.com/en-us and whose intended recipient is acdn.adnxs.com (subdomains not included) shall not be subject to any dynamic filtering rule.

You may expand on this system to allow for more granularity.
As this system is more advanced than the traditional four-component system, a warning must be included that this one is only for those that have mastered the old four-component system.

A specific URL where the issue occurs.

Steps to Reproduce

Expected behavior

Actual behavior

uBO version

1.52.2

Browser name and version

Operating System and version

@gwarser
Copy link

gwarser commented Oct 29, 2023

@user31415192 how would you design the UI for this?

@gorhill
Copy link
Member

gorhill commented Oct 29, 2023

Declining this, I don't see any value for the vast majority of users for me to completely rework code that has been stable since 2015. Best left to a specialized blocker to support that kind of finer-grained control, so whoever really wants this is welcome to invest their own time to scratch their own itch.

@Rudxain
Copy link

Rudxain commented Feb 8, 2024

@gorhill please close as "Not Planned". The current state is misleading

@gwarser gwarser closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined declined
Projects
None yet
Development

No branches or pull requests

4 participants