Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update filter list / add back purge button #3263

Closed
9 tasks done
whytf opened this issue Jun 4, 2024 · 13 comments
Closed
9 tasks done

Auto update filter list / add back purge button #3263

whytf opened this issue Jun 4, 2024 · 13 comments
Labels
duplicate This issue or pull request already exists

Comments

@whytf
Copy link

whytf commented Jun 4, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

I read that there is automatic filter update every hour, however thats far from the truth, whenever i visit site that updates their ad strategy often, it is either broken or ads shows up, before i used to just purge and update all lists in 2 clicks, now i have to unselect every single one, click apply, select every single one again and click update, just because someone decided that the button was unused.

I use this option too "Suspend network activity until all filter lists are loaded"

A specific URL where the issue occurs.

"everywhere" with often ad changes
youtube.com
facebook.com
twitch.tv
cnn.com

Steps to Reproduce

  1. Open any website that changes ad strategies often

Expected behavior

Either ublock updates all the lists on start or after couple minutes which would fix the problem right there

Or

purge button could be back so i can do it in 2 clicks instead of 30

Actual behavior

ads show, partly broken but still visible and obstructing

uBO version

1.58.0

Browser name and version

Brave 1.66.118 Chromium: 125.0.6422.147 (Official Build) (64-bit)

Operating System and version

Windows 11 Enterprise 23H2 (OS Build 22631.3593)

@gorhill
Copy link
Member

gorhill commented Jun 4, 2024

I read that there is automatic filter update every hour, however thats far from the truth

It's not "far from the truth", it is exactly how it works.

@whytf
Copy link
Author

whytf commented Jun 4, 2024

Well that must be pure coincidence that it never fixes on it's own and i have to do what purge button used to do, but someone knew better.

@whytf
Copy link
Author

whytf commented Jun 4, 2024

Even after waiting for several "1 hour" parts it didn't refresh the lists therefore same problem until i purged it myself

@garry-ut99
Copy link

garry-ut99 commented Jun 4, 2024

As far I know filter lists are updated every 5 hours, and uBO checks every 1 hour whether there are updated filter lists available, one should not confuse checking interval (every 1h) with filter lists updating interval (every 5h):
https://github.com/uBlockOrigin/uBlock-issues/wiki/Dashboard:-Filter-lists#auto-update-filter-lists

By the way, there are main/official threads for "Purge button" related discussion:
https://github.com/uBlockOrigin/uBlock-issues/wiki/Dashboard:-Filter-lists#purge-all-caches
Creating duplicate issues shoud be avoided, as there already exists a big pile of unnecessarily created duplicates.

As far I know the current approach instead of the old "Purge button", is that uBO devs should provide you a quick hot-fix link if there are some unfixed hot issues, which (the hot-fix link) will instantly update the necessary filter list for you, such hot-fix links, if necessary, are provided in the big cummulative official threads:

YouTube, Facebook or Twitch report.

@gwarser
Copy link

gwarser commented Jun 4, 2024

Duplicate of #3090

@gwarser gwarser marked this as a duplicate of #3090 Jun 4, 2024
@gwarser gwarser added the duplicate This issue or pull request already exists label Jun 4, 2024
@gwarser gwarser closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
@gorhill
Copy link
Member

gorhill commented Jun 5, 2024

I use this option too "Suspend network activity until all filter lists are loaded"

It's still not guaranteed to work for Chromium-based browsers. It's possible that just forcing a webpage reload yourself after uBO shows as ready would fix your issue.

@garry-ut99
Copy link

garry-ut99 commented Jun 5, 2024

Yes, it's also mentioned in documentation, I'm just providing some links:

It seems OP mixes two different cases of why ads leak for him, as some leaking / breakages might be unrelated to filter list updates (every 5 hour), they might be caused by Chromium's unability to filter ads at browser launch, even despite an user already has his filter lists up to date, in such case it's another duplicate of:

@gorhill
Copy link
Member

gorhill commented Jun 5, 2024

same problem

It's impossible to investigate exactly your problem if you are not very specific about it.

There are no widespread reports of the issue you mention. I personally never ever force a manual update and do not suffer the issue you mention (using Firefox). Provide a lot of details of what the "problem" is, which exact webpage, what exactly is wrong on that webpage, troubleshooting information, how many extensions you use, whether this occurs at browser launch, etc.

@garry-ut99
Copy link

Yes, lack of information from OP to properly diagnose.

whytf: now i have to unselect every single one, click apply, select every single one again and click update

No need to unselect & select anything: just simply clicking filter list clock icons should be sufficient to force differential update immediately if available, unless you want to say that clicking clock icons doesn't work for you.

@whytf
Copy link
Author

whytf commented Jun 21, 2024

Yes, lack of information from OP to properly diagnose.

whytf: now i have to unselect every single one, click apply, select every single one again and click update

No need to unselect & select anything: just simply clicking filter list clock icons should be sufficient to force differential update immediately if available, unless you want to say that clicking clock icons doesn't work for you.

Oh right, just click 37 times instead of 74, UI design of the century

@garry-ut99
Copy link

garry-ut99 commented Jun 22, 2024

whytf: Oh right, just click 37 times instead of 74

It was not supposed to be a solution for your issue, it's only a 2x faster version of your wrong workaround, while it stll doesn't solve your main issue, it at least halves its nuisance, better than nothing.

whytf: UI design of the century

And it has nothing to do with UI design, we already told you in previous comments that in normal conditions uBO should check for new filter lists automatically every hour (in practice real update occurs every 5 hours), and we said that if auto update fails for you, this indicates the occurrence of some kind of malfunction on your side, we can't investigate it without more details from you.

Maybe you should try to reproduce your issue on other browsers, for example Chrome instead of Brave, to rule out a possibility that your issue is related to Brave. Have you done it already? You should have done it already before reporting your issue....nobody knows whether you did it or not, because you didn't mention about it, hence we have to assume you still didn't. While uBO officially supports Chrome, it doesn't necessarily mean that there won't be problems on other Chromium forks, because other forks might contain modifications which can interfere with uBO and which uBO can't predict. Once you confirm that your issue still occurs in Chrome, we can try to continue to solve your issue.

whytf : UI design of the century

Unless you mean not the issue with auto-update broken on your side, but you mean that 1 hour / 5 hours check / update intervals is still insufficient for you, in such case you should continue your discussion in official threads mentioned in LINK to not mix your auto-update malfunction issue with the whole auto-update / purge button discussion, as they are two separate things.

@whytf
Copy link
Author

whytf commented Jun 24, 2024

should check

key word should

@gorhill
Copy link
Member

gorhill commented Jun 24, 2024

It all has been explained in details why the button was removed, and how people who do not understand how things work ended up thinking the button was magically creating filters out of thin air. I can't inject into people's head understanding of all the intricacies of filter lists update if they still do not understand after reading the documentation. If you still think you understand more than we do after reading the documentation, then it means you do not trust that we know what we are doing, in which case best is that you uninstall uBO and find something that suits you better.

Locking this thread, we do not need to keep repeating what has already been said, and we do not need to endless notifications leading nowhere on an already closed issue.

@uBlockOrigin uBlockOrigin locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants