Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some rules may break websites that use socks proxy in Firefox #3379

Closed
9 tasks done
ghcsd opened this issue Sep 17, 2024 · 6 comments
Closed
9 tasks done

Some rules may break websites that use socks proxy in Firefox #3379

ghcsd opened this issue Sep 17, 2024 · 6 comments
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed

Comments

@ghcsd
Copy link

ghcsd commented Sep 17, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Some rules may break websites that use socks proxy in Firefox

A specific URL where the issue occurs.

https://github.com/gorhill/uBlock

Steps to Reproduce

  1. Enable Socks5 proxy in Firefox.
Screenshots
  1. Ensure to enable Uncloak canonical names in uBlock.

  2. Ensure that uBlock filters - Privacy is enabled in the uBlock Filter lists, or add the following rules to My filters.
    *$all,ipaddress=0.0.0.0,domain=~0.0.0.0|~127.0.0.1|~[::1]|~[::]|~local|~localhost

  3. load https://github.com/gorhill/uBlock.

Screenshots

Possible related bug:

Developer tools always shows 0.0.0.0 as remote address when proxy is used
https://bugzilla.mozilla.org/show_bug.cgi?id=1445279


Sorry for my bad English.

Expected behavior

...

Actual behavior

The page is not fully loaded

uBO version

uBlock Origin 1.59.1.22

Browser name and version

Firefox Nightly 132.0a1 (2024-09-16)

Operating System and version

Windows 10

@gorhill
Copy link
Member

gorhill commented Sep 17, 2024

Enable Socks5 proxy in Firefox

I can reproduce when using Tor browser as proxy:

  • Launch Tor browser
  • Proxy settings:
    image

Especially, Proxy DNS when using SOCKS v5 must be check -- the issue is not reproducible without that setting.

Unfortunately, the bugzilla issue related to this is stale, so no workaround possible.

For now uBO will have to discard the browser-framework provided IP address when it's 0.0.0.0.

@HyperSoop
Copy link

Same here, using uBO in LibreWolf on Linux with a Tor SOCKS5 proxy, the uBlock filters - Privacy list breaks pretty much all websites catastrophically

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Sep 17, 2024

For now uBO will have to discard the browser-framework provided IP address when it's 0.0.0.0.

So, is it the dns.resolve() or onHeadersReceived()?

gorhill added a commit to gorhill/uBlock that referenced this issue Sep 17, 2024
@gorhill
Copy link
Member

gorhill commented Sep 17, 2024

So, is it the dns.resolve() or onHeadersReceived()?

It's browser-provided ip address to webRequest listeners, so onHeadersReceived().

1.59.1rc1 contains a tentative fix, to be confirmed by those suffering the issue.

@MasterKia
Copy link
Member

It's fixed for me.

@HyperSoop
Copy link

Works for me now too

@gwarser gwarser added bug Something isn't working Firefox specific to Firefox fixed issue has been addressed labels Sep 17, 2024
@gwarser gwarser closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

6 participants