-
Notifications
You must be signed in to change notification settings - Fork 17
Minor code cleaning #16
Comments
Oh, and there's one commit in there that I think is a bug fix, too: you used |
It's only available to those contributed in the past. |
Closing this in favour of the mergable link posted by the OP. Gorhill let me know if you want it to be kept opened. |
@rhendric I opened the repo in so that you can submit a PR with your changes -- which I just reviewed. Thank you for contributing and sorry for the delay. |
@gorhill, I'm still unable to create a PR. Instead of a button, I see, ‘An owner of this repository has limited the ability to open a pull request to users that have contributed to this repository in the past.’. |
That was opened at that time, it's been 17 hours now since, must have got locked again as you responded now. |
Ok, it's opened again. |
I've been hacking on uMatrix for my own purposes, and in the process I've found some bits of code that I'm 99% sure are useless. I'd like to submit a PR to remove them, but you seem to have forbidden that, which... well, your loss, I guess? But just in case you would find this particular contribution valuable, here's a link to my cleaning commits if you want to merge these yourself: gorhill/uMatrix@master...rhendric:cleaning
The text was updated successfully, but these errors were encountered: