Skip to content
This repository has been archived by the owner on Sep 19, 2020. It is now read-only.

Minor code cleaning #16

Closed
rhendric opened this issue Jun 1, 2018 · 7 comments
Closed

Minor code cleaning #16

rhendric opened this issue Jun 1, 2018 · 7 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@rhendric
Copy link

rhendric commented Jun 1, 2018

I've been hacking on uMatrix for my own purposes, and in the process I've found some bits of code that I'm 99% sure are useless. I'd like to submit a PR to remove them, but you seem to have forbidden that, which... well, your loss, I guess? But just in case you would find this particular contribution valuable, here's a link to my cleaning commits if you want to merge these yourself: gorhill/uMatrix@master...rhendric:cleaning

@rhendric
Copy link
Author

rhendric commented Jun 1, 2018

Oh, and there's one commit in there that I think is a bug fix, too: you used normalURL in a place where I think you meant pageUrl, although I haven't gone to all the trouble of finding a way to exercise that code path and observe the practical difference.

@uBlock-user
Copy link
Contributor

but you seem to have forbidden that

It's only available to those contributed in the past.

@gorhill

@uBlock-user uBlock-user added the enhancement New feature or request label Jun 1, 2018
@uBlock-user uBlock-user changed the title Minor code cleaning [PR substitute] Minor code cleaning Jul 27, 2018
@uBlock-user
Copy link
Contributor

Closing this in favour of the mergable link posted by the OP. Gorhill let me know if you want it to be kept opened.

@gorhill
Copy link
Member

gorhill commented Dec 30, 2018

@rhendric I opened the repo in so that you can submit a PR with your changes -- which I just reviewed. Thank you for contributing and sorry for the delay.

@rhendric
Copy link
Author

@gorhill, I'm still unable to create a PR. Instead of a button, I see, ‘An owner of this repository has limited the ability to open a pull request to users that have contributed to this repository in the past.’.

@uBlock-user
Copy link
Contributor

That was opened at that time, it's been 17 hours now since, must have got locked again as you responded now.

@gorhill
Copy link
Member

gorhill commented Dec 31, 2018

Ok, it's opened again.

@rhendric rhendric closed this as completed Jan 2, 2019
@uBlock-user uBlock-user added the fixed issue has been addressed label Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants