Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL partial write is not fully correct #9

Closed
ghost opened this issue Sep 16, 2018 · 2 comments
Closed

SSL partial write is not fully correct #9

ghost opened this issue Sep 16, 2018 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Sep 16, 2018

It does not send as far as possible, but returns if successful.

Either switch back to SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER or make us_ssl_socket_write call SSL_write in a loop.

v0.0.5

@ghost ghost added the bug label Sep 16, 2018
@ghost
Copy link
Author

ghost commented Sep 30, 2018

Tests need paritial write mode to pass, since the tests do not guarantee to call write with same content. Tests should be fixed, or we should swap to parital write and have it fixed.

@ghost
Copy link
Author

ghost commented Jan 25, 2019

We do use SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER currently, and tests pass. This is not exactly correct usage of SSL for the test being (the test should guarantee sending the same content again) but since it works, and it is only a test, it's fine.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants