Develop tests!!!

[uazo]

It is outrageous that this browser does not have an automatic test, I am ashamed, but it does.

• Remove GetInstalledRelatedApps API support #177

[uazo]

check https://github.com/GoogleChromeLabs/chrome-for-testing
https://docs.google.com/document/d/1XJvxyqAQjhPfJ0rX84PjfXXb5sBx3m8DXzMxR0ipQNs/edit

[PF4Public]

I think that Testing in Chromium page would be a good starting point.

According to it, not only they have unit tests, but also it would be possible to load pages in a test renderer (content_shell) and compare the rendered output or JavaScript output against an expected output file. All that from command line: out/Default/blink_unittests --gtest_filter='Foo*'

[uazo]

yes, i know that approach, i also used it some time ago, but

• currently, because of the changes, content_shell and the tests don't build. maybe the situation has changed since i removed the mega patch related to safebrowsing but probably a new patch is needed to reenable those builds, i had done it (it's somewhere in the history), i don't think it's worth it to try again.
• launching those tests in a ci is not a simple matter: in my docker image there is the necessary but it was difficult to maintain and required additional setup (and thus additional maintenance) and sometimes it didn't work because of some qemu trouble.
• developing "canonical" tests could weigh heavily on code maintenance during rebase and I would not want to increase the load.
• users would not be able to verify the tests

instead, my idea is to leverage javascript using the api provided in chromium, which allows me to expose java and c++ objects.
that way, i could use html+javascript to drive the tests, and i could probably make maintenance easy by embedding the "tests" within the patch code, which today i simply do via logs and then remove from code.

in this way i could also delegate the construction of the javascript infrastucture, because it would not be necessary to know either java or c++.

but for now it's just an idea, I've never tested it, and definitely something is missing from my analysis

[Krawei]

Ever thought of using OpenSUSE's OpenQA for your tests? The SUSE and Fedora Guys use it to test every package of their (semi) rolling release distributions against dozen of tests (for every single package) before the iso is going to be backed.

Maybe it is possible to use it for Android Development,too?

Link here:
https://open.qa/
https://fedoraproject.org/wiki/OpenQA

[PF4Public]

A somewhat related thing: implement some kind of testing server with the help of which any user could test their current browser for specific privacy issues, especially those, which are fixed in cromite, to have an easy way to verify that those fixes function and not got broken at some point.