Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results of OMMO dataset are not reproduced #22

Open
cmh1027 opened this issue Nov 1, 2024 · 0 comments
Open

Results of OMMO dataset are not reproduced #22

cmh1027 opened this issue Nov 1, 2024 · 0 comments

Comments

@cmh1027
Copy link

cmh1027 commented Nov 1, 2024

  1. Basically, the code can't deal with OMMO dataset because cameras in the OMMO dataset are RADIAL cameras.
  2. Even though I modify the dataset_readers.py code to accept the radial cameras like below,
        if intr.model=="SIMPLE_PINHOLE" or intr.model=="SIMPLE_RADIAL":
            focal_length_x = intr.params[0]
            FovY = focal2fov(focal_length_x, height)
            FovX = focal2fov(focal_length_x, width)
        elif intr.model=="PINHOLE" or intr.model=="OPENCV" or intr.model=="RADIAL":
            focal_length_x = intr.params[0]
            focal_length_y = intr.params[1]
            FovY = focal2fov(focal_length_y, height)
            FovX = focal2fov(focal_length_x, width)

the result is much lower. For example your paper states that metrics of "13" scene is 31.60 / 0.92 / 0.22, my result is 27.81 / 0.86 / 0.22

@cmh1027 cmh1027 changed the title Results of OMMO dataset is not reproduced Results of OMMO dataset are not reproduced Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant