Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

better threading docs required. & onContactsDataSourceReadySignal is not always dispatched to the main thread #37

Open
adam-zethraeus opened this issue Nov 7, 2016 · 3 comments
Labels

Comments

@adam-zethraeus
Copy link
Contributor

onContactsDataSourceReadySignal
2016-11-07 06:30:07.113 OhanaExample[71212:3367760] <NSThread: 0x7f83a6492460>{number = 2, name = (null)}

I think this was caused by the OHABAddressBookContactsDataProvider calling back on a background thread.

There's a generally larger task required here: Ohana's threading isn't very well defined.
We've generally assumed operation on Main. This is fine, but the contract with dataProviders and postProcessors should be better defined to dictate how they can offset work.

@maxwellE
Copy link
Contributor

maxwellE commented Mar 2, 2017

I can feel that we should always be on main thread in our callbacks. I wonder if @Darj should complete a possible RxSwift conversion before tackling this

@adam-zethraeus
Copy link
Contributor Author

yes, we should build this assumption into the framework.

@Darj
Copy link

Darj commented Mar 7, 2017

Yeah from memory all this pain was to do with the callback assumptions from UBSignals, the docs should be more explicit. While the Rx port will 'fix' this we should still update it here at some point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants