-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new parmater #20
Merged
rndquu
merged 1 commit into
ubiquity-os:development
from
whck6:feature/bot-strings-language-localization
Sep 6, 2024
Merged
feat: add a new parmater #20
rndquu
merged 1 commit into
ubiquity-os:development
from
whck6:feature/bot-strings-language-localization
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whck6
force-pushed
the
feature/bot-strings-language-localization
branch
7 times, most recently
from
September 3, 2024 09:01
a672137
to
dd8b24d
Compare
@rndquu Do you mind helping to review? |
rndquu
requested changes
Sep 3, 2024
rndquu
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@whck6 Overall looks good, pls add a real example of json
file with custom strings
whck6
force-pushed
the
feature/bot-strings-language-localization
branch
from
September 5, 2024 01:14
d56c8d3
to
fb4298e
Compare
rndquu
approved these changes
Sep 5, 2024
gentlementlegen
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenhao Ho [email protected]
Resolves #19