Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new parmater #20

Conversation

whck6
Copy link
Contributor

@whck6 whck6 commented Aug 31, 2024

Signed-off-by: Wenhao Ho [email protected]

Resolves #19

@whck6 whck6 force-pushed the feature/bot-strings-language-localization branch 7 times, most recently from a672137 to dd8b24d Compare September 3, 2024 09:01
@whck6 whck6 marked this pull request as ready for review September 3, 2024 09:16
@whck6
Copy link
Contributor Author

whck6 commented Sep 3, 2024

@rndquu Do you mind helping to review?

@rndquu rndquu self-requested a review September 3, 2024 10:42
README.md Outdated Show resolved Hide resolved
src/handlers/hello-world.ts Outdated Show resolved Hide resolved
@whck6 whck6 requested a review from rndquu September 4, 2024 03:49
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whck6 Overall looks good, pls add a real example of json file with custom strings

src/handlers/hello-world.ts Outdated Show resolved Hide resolved
@whck6 whck6 force-pushed the feature/bot-strings-language-localization branch from d56c8d3 to fb4298e Compare September 5, 2024 01:14
@whck6 whck6 requested a review from rndquu September 5, 2024 01:15
@rndquu rndquu merged commit 7e17676 into ubiquity-os:development Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot strings language localization
3 participants