Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global label change via config #18

Open
wants to merge 67 commits into
base: development
Choose a base branch
from

Conversation

Keyrxng
Copy link

@Keyrxng Keyrxng commented Jul 25, 2024

Resolves ubiquity-os/plugins-wishlist#8

  • adds a new config item globalConfigUpdate which contains enable: boolean, excludeRepos:[""]
  • I was able to re-use syncPriceLabelsToConfig() but it meant moving the typeguard check into the eventName switch case and out of the function
  • I had to fix eslint and ts errors which is why there are small changes across seemingly unrelated files
  • renamed setPrice to getPrice
  • removed logger.fatal() calls
  • salvaged most of the tests from my plugin

excludeRepos will have many uses but the reason that spurred me to include it was that in my QA devpool-directory was being updated with a green Price: $10 label when it should have a grey Pricing: $10 so that would likely be a default for us to include

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@gentlementlegen
Copy link
Member

@Keyrxng Can you please resolve the conflicts?

@Keyrxng
Copy link
Author

Keyrxng commented Sep 29, 2024

QA: https://github.com/ubq-testing/assistive-pricing/actions/runs/11088257095/job/30807939009

I use the worker for local testing but this is now an action plugin after this PR.

Auth:

image

Pre: 3x
image

Post: 3x
image

Pre: 10x
image

Post: 10x
image


The logic right now is like this:

  1. with globalConfigUpdate omitted, we simply update the repo labels and we do not update or remove labels from tasks.
  2. enabled, we delete any incorrect price label from issues according to the new reward bracket and then update all issues with time and priority labels with new pricing.

About number one, with it omitted, should this feature update currently priced tasks to the new bracket?

About two, should all time and priority labeled tasks have a price label applied to them? Or should they remain unpriced if they were unpriced before the run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

push/check modified base rate on base rate change
4 participants