Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New text config param for empty wallet #22

Closed
rndquu opened this issue Aug 14, 2024 · 8 comments · Fixed by #25
Closed

New text config param for empty wallet #22

rndquu opened this issue Aug 14, 2024 · 8 comments · Fixed by #25

Comments

@rndquu
Copy link
Contributor

rndquu commented Aug 14, 2024

Depends on ubiquity/safe.ubq.fi#3

We're going to have 2 registration flows:

  1. Our usual flow via the /wallet command
  2. A new one via webauthn and safe.ubq.fi (example)

The command-start-stop plugin displays a warning message when startRequiresWallet = true and user doesn't have a registered wallet:

Please set your wallet address with the /wallet command first and try again.

Since we're going to have 2 flows the message above is not applicable for the "webauthn" flow. Possible solution could be to add a new plugin option for the warning message like emptyWalletText.

@gentlementlegen
Copy link
Member

@whck6 you should first /start to assign yourself to this issue and notify users that you are working on it.

@whck6
Copy link
Contributor

whck6 commented Aug 28, 2024

/wallet 0x1133830C73B2251DB9373e1B668D01E9dd2B99B1

Copy link
Contributor

ubiquity-os bot commented Aug 28, 2024

+ Successfully registered wallet address

@whck6
Copy link
Contributor

whck6 commented Aug 28, 2024

/start

Copy link
Contributor

ubiquity-os bot commented Aug 28, 2024

DeadlineWed, Aug 28, 2:47 PM UTC
Registered Wallet 0x1133830C73B2251DB9373e1B668D01E9dd2B99B1
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link
Contributor

ubiquity-os bot commented Aug 31, 2024

[ 25 WXDAI ]

@whck6
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Review Comment 6 0
Conversation Incentives
Comment Formatting Relevance Reward
Resolves #22
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0
    score: 1
multiplier: 0
0.1 -
I've added a new config it is called emptyWalletText.
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 10
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
@Keyrxng Do you mind checking?
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 5
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
Updated. @rndquu I am misunderstanding and removed [it](https:…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 8
        multiplier: 0.2
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
Updated. @rndquu
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 2
        multiplier: 0.2
    score: 1
multiplier: 0
1 -
Updated.
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.2
    score: 1
multiplier: 0
1 -

[ 0.21 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.21
Conversation Incentives
Comment Formatting Relevance Reward
@whck6 you should first `/start` to assign yourself to t…
2.1
content:
  p:
    symbols:
      \b\w+\b:
        count: 20
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
multiplier: 1
0.1 0.21

[ 27.2 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Issue Specification 1 22.2
Review Comment 5 5
Conversation Incentives
Comment Formatting Relevance Reward
Depends on https://github.com/ubiquity/safe.ubq.fi/issues/3 We'…
22.2
content:
  p:
    symbols:
      \b\w+\b:
        count: 34
        multiplier: 0.1
    score: 1
  ol:
    symbols:
      \b\w+\b:
        count: 37
        multiplier: 0.1
    score: 0
  li:
    symbols:
      \b\w+\b:
        count: 30
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 5
  a:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 5
  pre:
    symbols:
      \b\w+\b:
        count: 13
        multiplier: 0.1
    score: 0
multiplier: 3
1 22.2
The newly added `emptyWalletText` param should be used […
0.325
content:
  p:
    symbols:
      \b\w+\b:
        count: 11
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
multiplier: 0.25
1 0.325
That's kind of overengineering, I'd keep a single param and intr…
0.55
content:
  p:
    symbols:
      \b\w+\b:
        count: 22
        multiplier: 0.1
    score: 1
multiplier: 0.25
1 0.55
https://github.com/ubiquibot/plugin-template/issues/19
0.2
content:
  p:
    symbols:
      \b\w+\b:
        count: 8
        multiplier: 0.1
    score: 1
multiplier: 0.25
1 0.2
Let's just make the text configurable and decide later on the ex…
3.3
content:
  p:
    symbols:
      \b\w+\b:
        count: 48
        multiplier: 0.1
    score: 1
  ol:
    symbols:
      \b\w+\b:
        count: 72
        multiplier: 0.1
    score: 0
  li:
    symbols:
      \b\w+\b:
        count: 66
        multiplier: 0.1
    score: 1
  a:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 17
        multiplier: 0.1
    score: 1
multiplier: 0.25
1 3.3
Works fine. @whck6 Could you also update readme docs https://git…
0.625
content:
  p:
    symbols:
      \b\w+\b:
        count: 25
        multiplier: 0.1
    score: 1
multiplier: 0.25
1 0.625

[ 28.7 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Review Comment 3 28.7
Conversation Incentives
Comment Formatting Relevance Reward
@rndquu There was a slight variance here because this comment is…
6.4
content:
  p:
    symbols:
      \b\w+\b:
        count: 61
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 3
        multiplier: 0.1
    score: 1
multiplier: 1
1 6.4
@whck6 Thanks for the PR. Just so you know, this PR can't be me…
18.8
content:
  h2:
    symbols:
      \b\w+\b:
        count: 89
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 1
  p:
    symbols:
      \b\w+\b:
        count: 98
        multiplier: 0.1
    score: 1
multiplier: 1
1 18.8
@rndquu my mistake I misunderstood things originally, confused m…
3.5
content:
  p:
    symbols:
      \b\w+\b:
        count: 35
        multiplier: 0.1
    score: 1
multiplier: 1
1 3.5

@whck6
Copy link
Contributor

whck6 commented Aug 31, 2024

@Keyrxng, May I know when I will receive 25 WXDAI? I feel It would be immediate but no.

@Keyrxng
Copy link
Contributor

Keyrxng commented Aug 31, 2024

@whck6 is your permit above not working?

We are aware of a slight issue with permit generation at the moment which is being resolved as we speak. If we need to we will regenerate the permit if you haven't claimed it by then but things will be resolved within 24 hrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants