Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Backoff Instead of Fail #4

Closed
0x4007 opened this issue Mar 25, 2024 · 8 comments · Fixed by #63
Closed

Exponential Backoff Instead of Fail #4

0x4007 opened this issue Mar 25, 2024 · 8 comments · Fixed by #63

Comments

@0x4007
Copy link
Member

0x4007 commented Mar 25, 2024

I guess my aspiration would be that we can handle situations where we fail to retrieve the data elegantly. What about an exponential back off? The GitHub action has the ability to run for six hours!

Otherwise, if that's a bad idea then yes I agree with whilefoo that it should throw and exit the process.

I'm still definitely leaning towards exponential backoff idea though, which implies that it should never be null, but instead perhaps, undefined.

This can be addressed in another task

Originally posted by @pavlovcik in #3 (comment)

@PhantomCracker
Copy link

@0x4007 is this still available?
I was thinking on implementing a backoff solution, but I already see some changes there:
self: GitHubIssue | null = null;

@0x4007
Copy link
Member Author

0x4007 commented Jun 14, 2024

@gentlementlegen did you implement this in the new plugin? Never let it fail, just exponential back off!

@gentlementlegen
Copy link
Member

@0x4007 Partially, but there should be fatal errors that still stop the plugin from running otherwise it would indefinitely fail isn't it?

@0x4007
Copy link
Member Author

0x4007 commented Jun 15, 2024

This task is strictly about collecting the information that it should have access to from GitHub. Six hour hard timeout anyways.

@gentlementlegen gentlementlegen self-assigned this Jul 19, 2024
Copy link

ubiquibot bot commented Jul 19, 2024

@gentlementlegen the deadline is at 2024-07-19T02:16:56.547Z

Copy link

ubiquibot bot commented Jul 19, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot-dev bot commented Jul 19, 2024

[ 25 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 25
Issue Comment 1 0
Conversation Incentives
Comment Formatting Relevance Reward
@0x4007 Partially, but there should be fatal errors that still s…
0
content:
  p:
    count: 22
    score: 1
wordValue: 0
formattingMultiplier: 0
0.8 -

[ 0.56 WXDAI ]

@PhantomCracker
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.56
Conversation Incentives
Comment Formatting Relevance Reward
@0x4007 is this still available? I was thinking on implementing …
0.8
content:
  p:
    count: 26
    score: 1
  code:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 0.25
0.7 0.56

[ 0 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Conversation Incentives
Comment Formatting Relevance Reward

Copy link

ubiquibot bot commented Jul 19, 2024

[ 7.6 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification10
IssueComment27.6
Conversation Incentives
CommentFormattingRelevanceReward
> I guess my aspiration would be that we can handle situation...
-1-
@gentlementlegen did you implement this in the new plugin? Never...
3.40.813.4
This task is strictly about collecting the information that it s...
4.20.424.2

[ 2.65 WXDAI ]

@PhantomCracker
Contributions Overview
ViewContributionCountReward
IssueComment12.65
Conversation Incentives
CommentFormattingRelevanceReward
@0x4007 is this still available? I was thinking on implementing...
2.65
code:
  count: 1
  score: "0.25"
  words: 4
0.352.65

[ 61.9 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask125
IssueComment10
IssueComment12.3
ReviewComment217.3
ReviewComment217.3
Conversation Incentives
CommentFormattingRelevanceReward
@0x4007 Partially, but there should be fatal errors that still s...
-0.49-
@0x4007 Partially, but there should be fatal errors that still s...
2.30.492.3
## What's new When retrieving the comments, if there is any fai...
13.2
h2:
  count: 2
  score: "2"
  words: 5
code:
  count: 1
  score: "1"
  words: 1
0.513.2
@0x4007 We can do that although in this case it cannot be more t...
4.10.374.1
## What's new When retrieving the comments, if there is any fai...
13.2
h2:
  count: 2
  score: "2"
  words: 5
code:
  count: 1
  score: "1"
  words: 1
0.513.2
@0x4007 We can do that although in this case it cannot be more t...
4.10.374.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants