Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier error comment and refinements #26

Open
Keyrxng opened this issue Oct 30, 2024 · 2 comments
Open

Prettier error comment and refinements #26

Keyrxng opened this issue Oct 30, 2024 · 2 comments

Comments

@Keyrxng
Copy link
Member

Keyrxng commented Oct 30, 2024 

          I think room creation failure is important to understand that it tried to open it but failed; closing errors might be silent. We always have the logs in the Actions and Cloudflare logs if needed. But yes we should discuss these in details. We can keep the closing error but we need a prettier message at least.

Originally posted by @gentlementlegen in ubiquity-os-marketplace/command-start-stop#70 (comment)
@Keyrxng
Copy link
Member Author

Keyrxng commented Oct 30, 2024

lmao, wrong repo and I don't have access to close or transfer

Open
@gentlementlegen gentlementlegen transferred this issue from ubiquity-os-marketplace/command-start-stop Oct 30, 2024
Open
@Keyrxng
Copy link
Member Author

Keyrxng commented Oct 30, 2024

Merged #28 with a quick fix to stop the error posts right now but I will improve the error comment posting system and aim to give it more structure than just !== 200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Keyrxng