Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards for simplifying/cleaning code #33

Open
0x4007 opened this issue Aug 1, 2024 · 1 comment
Open

Rewards for simplifying/cleaning code #33

0x4007 opened this issue Aug 1, 2024 · 1 comment

Comments

@0x4007
Copy link
Contributor

0x4007 commented Aug 1, 2024

I was working on this pull and thought it could be cool to have a small reward for simplifying the codebase.

Diff stats:

+5426
-6760

A simple formula could be to divide by 10 then subtract. i.e. 676 - 542.6 = $133.4

With our strict linter rules we should be able to avoid BS refactors.

Rationale

Generally codebase maintainers should try and keep the code clean and simple. This offers a direct financial incentive for everybody to do so. Our task oriented system is not very compatible with the continuous nature of code simplification and reduction, so this plugin addresses that.

Filters

We can use filename regex to make specific types of files eligible such as *.ts, *.sol

Remark

This is intended to be stacked on regular task related pulls as well (it doesn't need to be a dedicated refactor pull.)

@gentlementlegen
Copy link
Member

Sounds a bit dangerous if we don't ignore some files, we might need some filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants