Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: purge rewards and format #14

Merged
merged 6 commits into from
Apr 23, 2024
Merged

chore: purge rewards and format #14

merged 6 commits into from
Apr 23, 2024

Conversation

Keyrxng
Copy link
Member

@Keyrxng Keyrxng commented Mar 13, 2024

Relates to ubiquity/.github#98

I guess it doesn't really but sort of
  • purged /rewards
  • brought over the used constants and abis
  • yarn format fixes

@Keyrxng Keyrxng mentioned this pull request Mar 13, 2024
Closed
@rndquu
Copy link
Member

rndquu commented Mar 13, 2024

@Keyrxng The build workflow is failing :(

@Keyrxng
Copy link
Member Author

Keyrxng commented Mar 13, 2024

yarn knip is passing but the workflow isn't I'm unsure how to approach that but the build should pass now that I've removed the lib causing the issue

0x4007
0x4007 requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks mostly fine just cspell related nits

.cspell.json Outdated Show resolved Hide resolved
.cspell.json Outdated
],
"dictionaries": ["typescript", "node", "software-terms", "html"],
"import": ["@cspell/dict-typescript/cspell-ext.json", "@cspell/dict-node/cspell-ext.json", "@cspell/dict-software-terms"],
"ignoreRegExpList": ["[0-9a-fA-F]{6}"]
"ignoreRegExpList": ["[0-9a-fA-F]{6}"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for colors? Where is the issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just because I've added a comma it's registering a full line change but no dramas

@gitcoindev gitcoindev mentioned this pull request Mar 18, 2024
Merged
@gitcoindev
Copy link
Contributor

Hi @Keyrxng , the Knip configuration was fixed #19 , most likely you will encounter merge conflicts in this area. After the merge conflicts are resolved I will also review and the pull request can be merged.

@Keyrxng
Copy link
Member Author

Keyrxng commented Mar 20, 2024

@gitcoindev ready when you are

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Mar 20, 2024 •
edited
Loading

@Keyrxng
Copy link
Member Author

Keyrxng commented Apr 23, 2024

Is this ready to be merged?

@gitcoindev
Copy link
Contributor

@Keyrxng thank you for pinging me again, yes!

@gitcoindev gitcoindev merged commit 902ff2b into ubiquity:development Apr 23, 2024
4 checks passed
@Keyrxng
Copy link
Member Author

Keyrxng commented Apr 23, 2024

thank you for pinging me again

I can never tell if it's rude of me to be pinging or if that should be the default lmao I get you folks are busy but cheers

@gitcoindev
Copy link
Contributor

thank you for pinging me again

I can never tell if it's rude of me to be pinging or if that should be the default lmao I get you folks are busy but cheers

In my case: If I do not reply within 48hrs, do ping me -)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 approved these changes

@rndquu rndquu rndquu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Keyrxng @rndquu @gitcoindev @0x4007