You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
We should parse the permit generation comments using URLSearchParams because we may add more URL search parameters to the URL in the future. Also the current approach is strict on the ordering of the parameters which seems brittle.
Yes, parsing the URL with URLSearchParams is a better approach
This PR solves the original issue + we don't have plans of adding more query params besides claim and network so I don't think that refactoring to URLSearchParams is an urgent issue
Besides, isn't it supposed to be https://pay.ubq.fi/?claim=
No, the generated URL is https://pay.ubq.fi?claim= so everything is fine
We should parse the permit generation comments using
URLSearchParams
because we may add more URL search parameters to the URL in the future. Also the current approach is strict on the ordering of the parameters which seems brittle.Originally posted by @rndquu in #508 (comment)
The text was updated successfully, but these errors were encountered: