Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

time-labels config auto generation #584

Closed
0x4007 opened this issue Aug 6, 2023 · 10 comments
Closed

time-labels config auto generation #584

0x4007 opened this issue Aug 6, 2023 · 10 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Aug 6, 2023

The time-labels config should be automatically calculated using the ms library. Partners shouldn't need to override the time labels and insert into the config.

{
  "time-labels": [
    {
      "name": "Time: <1 Hour",
      "weight": 0.125,
      "value": 3600
    },
    {
      "name": "Time: <1 Day",
      "weight": 1,
      "value": 86400
    },
    {
      "name": "Time: <1 Week",
      "weight": 2,
      "value": 604800
    },
    {
      "name": "Time: <2 Weeks",
      "weight": 3,
      "value": 1209600
    },
    {
      "name": "Time: <1 Month",
      "weight": 4,
      "value": 2592000
    }
  ],
}

https://github.com/ubiquity/ubiquibot/pull/558/files#diff-6863b0d0a0dcd10927da34fbf604b6226c24c1b204008d06f10b20da8d85c5d3R5-R31

@devpanther
Copy link
Contributor

devpanther commented Aug 7, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented Aug 7, 2023

Deadline Tue, 08 Aug 2023 18:44:29 GMT
Registered Wallet 0xf76F1ACB66020f893c95371f740549F312DEA3f1
Payment Multiplier 1.00
Multiplier Reason Default
Total Bounty 300 USD
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @devpanther
    Copy link
    Contributor

    Partners shouldn't need to override the time labels and insert into the config.

    I think that's the default config you linked to, I think the overrides takes place in the yml file.

    Do you mean, it should not be hardcoded there but rather generated on install

    @0x4007
    Copy link
    Member Author

    0x4007 commented Aug 7, 2023

    I think that we shouldn't need to override in any default settings anywhere. Instead, I feel that the bot should just understand Time labels and their values based on what ms library returns.

    However, we should retain the override capability in case some partner needs it for some reason. But we should not have overrides in our default settings, it should just figure it out on the fly.

    @devpanther
    Copy link
    Contributor

    I feel that the bot should just understand Time labels and their values based on what ms library returns.

    So basically labels can be custom (added to issues) and it'd just automatically turn the 1.5 Week for example to ms and calculate the amount

    And we should remove time-labels from config

    @0x4007
    Copy link
    Member Author

    0x4007 commented Aug 7, 2023

    I also want to dock time from the larger resolutions to count for inefficiencies. Only hours and below are exceptions because this level of precision should be pretty accurate.

    However for the less accurate estimates, I have data to back that motivated people work at usually 75% efficiency:

    • Hours = No change
    • Days = 6 Hours
    • Weeks = 30 Hours
    • Months = 120 Hours

    Examples

    • Time: 4 Hours = credit for 4 units of time
    • Time: 0.5 Days = 3 units of time credit
    • Time: 0.5 Weeks = 15 units
    • Time: 0.5 Months = 60 units.

    This is opinionated so I fear that there is a possibility that we might need to adjust after running and observing this in action for awhile.

    @devpanther
    Copy link
    Contributor

    @pavlovcik Auto-generation of Time labels will be disabled right? Since we no longer have strictly default time labels

    @0x4007
    Copy link
    Member Author

    0x4007 commented Aug 9, 2023

    @pavlovcik Auto-generation of Time labels will be disabled right? Since we no longer have strictly default time labels

    That makes sense.

    To clarify, you mean that when the bot is added to your repository, the time labels are not automatically generated and added to the repository?

    However, I think that if they enable assistive-pricing it is A LOT easier for them to onboard if we give them some basic time labels to start with. At least Time: <1 Hour; Time: <1 Day; Time: <1 Week labels.

    (I kind of want to add <4 Hours because in the last week it was needed twice!)

    @0x4007
    Copy link
    Member Author

    0x4007 commented Aug 9, 2023

    I just realized that this is the only way for the bot to know what labels to automatically populate @devpanther so this task actually is invalid, my apologies.

    @0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Aug 9, 2023

    Permit generation skipped because the issue was not closed as completed

    If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

    @devpanther devpanther removed their assignment Aug 10, 2023
    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants