fix: add polkit rules for yubikey #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleGospo
approved these changes
May 1, 2024
|
@rothgar we are getting some CI failures. |
rothgar
commented
May 3, 2024
| %setup -q -c -T | ||
|
|
||
| %install | ||
| tar xf %{SOURCE0} -C %{buildroot}%{_datadir}/%{VENDOR} --strip-components=1 |
There was a problem hiding this comment.
I think this may be causing the CI problems. From the logs
tar xf /tmp/ublue-os/rpmbuild/SOURCES/ublue-os-polkit-rules.tar.gz -C /tmp/ublue-os/rpmbuild/BUILDROOT/ublue-os-polkit-rules-0.1-1.fc39.x86_64/usr/share/ublue-os --strip-components=1
tar: /tmp/ublue-os/rpmbuild/SOURCES/ublue-os-polkit-rules.tar.gz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
There was a problem hiding this comment.
It's been a long time since I packaged anything in RPM. @storopoli Do you know why it may not be creating the tar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know there's something I'm missing because I haven't tested this and it's been a long time since I've built RPMs. I copied the examples from the udev spec.
I think I'll need to update the Containerfile too but would be happy to get some guidance so I can also verify it builds. I also need to add a post install restart for pcscd service
Referencing ublue-os/main#500
Should also fix #180