Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gemmini Spike test in CI + Fix FireMarshal launch jobs erroring #1804

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Feb 26, 2024

This fixes two issues:

  • When FireMarshal would run a job with launch, if the job failed it would still "pass" returning error code 0. This change to FireMarshal makes return a non-zero error code if the job failed.
  • Bumps Gemmini to get the most recent libgemmini changes.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez self-assigned this Feb 27, 2024
@abejgonzalez abejgonzalez changed the title WIP: Fix Gemmini Spike test in CI + Fix FireMarshal launch jobs erroring Fix Gemmini Spike test in CI + Fix FireMarshal launch jobs erroring Feb 27, 2024
@abejgonzalez abejgonzalez merged commit b7c20b6 into main Feb 27, 2024
52 of 53 checks passed
@abejgonzalez abejgonzalez deleted the gemmini-ci-fix branch July 4, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants