-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qset standardization, preflight checks + various smaller patches #124
Open
fudgeu
wants to merge
14
commits into
ucfopen:dev/3.0.3
Choose a base branch
from
fudgeu:patpatches
base: dev/3.0.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dancy and enable the 'Download Package' button on the splash screen, started working out backend logic for making preflight checks.
…o the output from the preflight checklist. Covered all checks so far.
- Qset will now be forced to conform to the same structure that Materia Docker enforces it to be
…ue/43 # Conflicts: # assets/css/mwdk-download.css # express.js # views/download.html # views/index.html
# Conflicts: # .gitignore # express.js
fudgeu
changed the title
Qset standardization + various smaller patches
Qset standardization, preflight checks + various smaller patches
Oct 22, 2024
Issue/43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built off of dev/3.0.3 and requires that to be merged in first
This PR includes a many fixes and patches for various things:
install.yaml
(files.player, files.creator, score.score_screen). Appropriately,webpack.config.js
must be configured to output widget files using those same names.install.yaml
is validated as part of the preflight checks above.webpack.config.js
orwebpack.config.cjs
when initializing. This allows the easy use of an explicitly-defined CommonJS webpack config, saving some headaches when your project is using"type": "module"
(like Pyramid Game is)The only thing not addressed in the original issue is #21, or any of the 'qset editor' or 'install.yaml editor's mentioned in any of the other issues