Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to call dsymutil on built binaries #409

Closed
gcode-importer opened this issue Oct 6, 2014 · 5 comments
Closed

Add option to call dsymutil on built binaries #409

gcode-importer opened this issue Oct 6, 2014 · 5 comments
Assignees

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 409

This is useful to run automated test with ASan and/or valgrind on MacOS.
 It's less useful under valgrind which can do this on its own with the proper option,
but will do it for every call instead of just once.

Patch has been tested against CDash. Proper symbol output with valgrind (no ASan problems
reported under CDash but checked locally with specific files)

Feel free to rename the option if doesn't follow some CMake convention (I'm not used
to CMake yet...)

Reported by mayeut on 2014-10-06 21:36:10


- _Attachment: [dsymutil.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-409/comment-0/dsymutil.patch)_
@gcode-importer
Copy link
Author

Reported by mayeut on 2014-10-06 21:50:02

  • Labels added: Type-Enhancement
  • Labels removed: Type-Defect

@gcode-importer
Copy link
Author

+cc Mathieu Malaterre

Hi Mathieu (Malaterre), could you validate this patch that add a way to generate debug
symbols useful for ASan when building on OSX ? As it's a CMake issue, I would prefer
you handle it. Thanks.

Reported by detonin on 2014-10-14 15:05:47

@gcode-importer
Copy link
Author

patch looks good. I would have prefixed USE_DSYMUTIL with OPJ_ since this is very openjpeg
specific.

Reported by malaterre on 2014-10-14 15:10:53

@gcode-importer
Copy link
Author

Changed patch to prefix with OPJ_

Reported by mayeut on 2014-10-14 16:06:30


- _Attachment: [dsymutil.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-409/comment-4/dsymutil.patch)_

@gcode-importer
Copy link
Author

This issue was closed by revision r2903.

Reported by detonin on 2014-10-15 10:25:06

  • Status changed: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants