Add 'text' to auto-format query method #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As auto-format rules run before text is inserted into the editor, when you use the query option to control validity you cannot access the last thing the user entered. In the case of code-blocks which should be '```` the query method can only derive '``' from the editor (currentNode). This PR ensure the last thing typed is also passed into the query method.
🦋 Changeset detectedLatest commit: a8d7b40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/udecode/plate/9gYiFQJ7zEMFSvPxacd6uWZScx2V |
zbeyens
reviewed
Sep 22, 2021
zbeyens
reviewed
Sep 22, 2021
zbeyens
reviewed
Sep 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As auto-format rules run before text is inserted into the editor, when you use the query option to control validity you cannot access the last thing the user entered. In the case of code-blocks which should be '```' the query method can only derive '``' from the editor.
This PR ensure the last thing typed is also passed into the query method.
Checklist
yarn test.yarn lint. (Fix errors withyarn lint --fix.)yarn docs.)