Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yjs] Add preliminary cursor rendering support #2527

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drewag
Copy link

@drewag drewag commented Jul 18, 2023

Description
This adds the ability to render custom cursors from Yjs. It does not provide a default rendering and it does not update active users.

This adds the ability to render custom cursors from Yjs. It does not
provide a default rendering and it does not update active users.
@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023

⚠️ No Changeset found

Latest commit: 953af1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 9:10pm

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 18, 2023

AI-Generated Summary: This pull request provides preliminary support for rendering custom cursors within the yjs package. This update doesn't have any default rendering included yet, neither does it update active users. This patch specifically adds a new file, RemoteCursorOverlay.tsx, in the yjs package which contains logic for rendering the cursor overlay. Changes have also been made to package.json in yjs, providing an additional dependency for @slate-yjs/react. Lastly, the RemoteCursorOverlay was exported in the index file of the yjs package.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 18, 2023

Thank you @drewag for this first contribution!

@reviewpad reviewpad bot added the medium Pull request is medium label Jul 18, 2023
@ghost
Copy link

ghost commented Jul 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@natamox
Copy link
Collaborator

natamox commented Mar 31, 2024

Is there any progress? I think it's a good one.

@beeant0512
Copy link
Contributor

is there a example how to use the CursorOverlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants