-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport infrastructure data packs are out #116
Comments
The current workflow can be optimised. Currently is as follows:
Through R, step 2 is taking a considerable amount of time (~1 minute per LAD, in full there are over 330 I believe) In #49 @bdon proposed the use of the osmium-tool which can be used to generate extracts from a large single file (say, england-latest.osm.pbf). This requires a config file (.JSON) that specifies boundaries to be used for each region. I imagine it can be simple to save each LAD polygon as a single .geojson to be used by the osmium-tool as a boundary - the fun part will be linking these up into a config file to be read by the osmium-tool... the given example:
output: the name of the extract .osm.pbf to be generated I've had a quick look and it seems this file will need to be written by hand, wich for a few hundred LADs will be repetative, but I think once this is set up it can be reused, provided the file_name of each LAD polygon stays the same. Given the time constraints left on the project this is not something I am prioritising, but if there is a rainy weekend I may try to write a script that can write such a config file to be used by the osmium-tool. The benefit of this would be, rather than oe_read() reading and subsetting from the entire england-latest.osm.pbf, it would only read from a much smaller, nearly perfect .osm.pbf. |
Update:
To reduce this, I propose we could try packaging data packs by region into a single .zip (inc. the .geojson & .gpkg formats - or another other compressed format) and upload these reducing total uploads to around 630. Alternatively, we could package all lines and all points into respective zipped directories and upload these two to releases. Though, this would require planners to download the data for all of England before finding their specific regions. |
After seeing Robin's issue #128, I had a look at the vignette too and noticed a few mismatches(?) re IM function:
to
Also, I believe there's a separate lit function now, then creating this column as part of im function becomes rather redundant too. There's a lack of consistency that may cause confusion for a potential user. |
Yes this vignette needs updating! To clarify - this issue was not promoting the vignette as being published, rather it was promoting that actual data packs had been made available through 0.4 releases.
This vignette actually hasn't been updated since the steering group meeting with Kayley towards the end of July I think, which may be the reason for some of the discrepancies.
Originally I had intended to include all of the IM function columns within the meeting, however I believe that there are an additioanl 11 columns returned by the IM function, and at the time of compiling I didn't have time to create individual .html maps for each.
This is actually the original reason for why I had removed im_lighting from the IM function within the data packs as I had created the oi_is_lit function at this point. Apologies I had forgot to specify within the vignette and did not want to edit your vignette in case you had linked this in a personal website or if it has been included in any publications etc. I'll get to work on updating the vignette now. |
Thanks James for clarifying. I don't link to individual functions on my website as I see the project in it's totality. It's an interesting point, so maybe we should discuss this at some point as I've noticed that you add your name to every vignette your start but neither I nor Robin have done it. Maybe it's something we should discuss. I guess just because something has been mentioned in the publication, it doesn't mean it stops being a subject to changes. So I'd say as long as the communication/updating is clear then we can avoid miscommunication in the future. We might simply start keeping a log of changes of documentation/vignete/etc specifically used in publications. Changes are unavoidable in the ongoing open source projects. |
The (current version) of transport infrastructure data packs are out (/being processed & published) under the 0.4 releases!
Data packs are currently generated through: create_data_packs.R
These data packs contain the following function outputs:
The text was updated successfully, but these errors were encountered: