Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Suggestion opens even if current user didn't type the trigger #4183

Open
2 tasks done
bjgrosse opened this issue Jul 6, 2023 · 1 comment
Open
2 tasks done
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug

Comments

@bjgrosse
Copy link

bjgrosse commented Jul 6, 2023

Which packages did you experience the bug in?

suggestion

What Tiptap version are you using?

2.0.0

What’s the bug you are facing?

In a collaborative editor, if you have a suggestion-based extension (like Mention), and your cursor is at the same location as another user's when that user types the trigger character, you'll get the suggestion UI even tho you didn't type the character:

msedge_id56qX6sj3

Seems like one way to solve this is to only show the UI if the trigger character was just typed, as opposed to any time the cursor is positioned after the character. Is there any way to configure this kind of behavior currently?

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

I wouldn't expect one user triggering a suggestion causing the suggestion UI to show for other users with cursors in the same location.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@bjgrosse bjgrosse added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug labels Jul 6, 2023
@bjgrosse
Copy link
Author

bjgrosse commented Jul 6, 2023

(Pro subscriber, btw.. sorry I clicked the wrong link!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug
Projects
Status: Triage open
Development

No branches or pull requests

3 participants