Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on CICE albedos in coupled model and create initial P8 feature set tests #854

Closed
DeniseWorthen opened this issue Oct 6, 2021 · 0 comments · Fixed by #944
Closed
Labels
enhancement New feature or request

Comments

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Oct 6, 2021

Description

CICE albedos are available for use in the coupled model after PRs #723, #701. Use of CICE albedos is controlled with namelist parameter use_cice_alb.

Solution

Since this feature is planned for inclusion in P8 and the code is already committed, the default_vars export_cpl should be modified

diff --git a/tests/default_vars.sh b/tests/default_vars.sh
index 14315a13..aaa06d83 100755
--- a/tests/default_vars.sh
+++ b/tests/default_vars.sh
@@ -1120,8 +1120,9 @@ export USE_CICE_ALB=.false.
 export KTHERM=2
 export TFREEZE_OPTION=mushy

+# P8 CICE Albedos
+export USE_CICE_ALB=.true.

In cpld_bmark_p7 (and the 35d version), turn the feature off

diff --git a/tests/tests/cpld_bmark_p7 b/tests/tests/cpld_bmark_p7
index 62fcdf32..2fd7dda2 100644
--- a/tests/tests/cpld_bmark_p7
+++ b/tests/tests/cpld_bmark_p7
@@ -142,5 +142,6 @@ export RST_END=$RUN_END
 export RST_2_END=$RUN_END

 export USE_CICE_ALB=.false.
 export CCPP_SUITE=FV3_GFS_v16_coupled_nsstNoahmpUGWPv1
 export FV3_RUN=cpld_control_run.IN

The oRTs should be run using a feature branch containing these changes. If all oRTs pass, a PR should be opened to commit these changes and enable this feature. This will require renaming the tests and updating rt.conf

Alternatives

Related to

  • required to support P8
@DeniseWorthen DeniseWorthen added the enhancement New feature or request label Oct 6, 2021
@DeniseWorthen DeniseWorthen changed the title Turn on use of CICE albedos in coupled model; add regression test for this feature Update P8 feature set to include CICE albedos in coupled model Dec 3, 2021
@DeniseWorthen DeniseWorthen changed the title Update P8 feature set to include CICE albedos in coupled model Turn on CICE albedos in coupled model and create initial P8 feature set tests Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant