Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Change the architecture/lifecycle of the plugin (run in exit phase) #101

Open
petermuessig opened this issue May 30, 2023 · 2 comments
Assignees

Comments

@petermuessig
Copy link
Member

As mentioned by @Elberet in #23 and #25, to benefit from other plugins transformation process, the plugin should run in the Program#exit phase. This ensures that e.g. custom code for TypeScript isn't needed to process e.g. the constructor parameter properties, or to let the decorator plugin handle them. But therefore the plugin still needs to partially run in the Program#enter phase to collect informations about imports, custom decorators or any processing relevant information which may get lost during the transformation phase.

@petermuessig petermuessig self-assigned this May 30, 2023
@texttechne
Copy link

Hi @petermuessig,

I saw the commit and tried it out with decorators. It works. So this issue can be closed?

And big thanks for tackling this issue!

@petermuessig
Copy link
Member Author

Within the re-architecture of the plugin we may also checkout how to handle circular dependencies better. Therefore we need a holistic picture of the resources - more can be found in the issue #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants