Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authentication capabilities #369

Merged
merged 37 commits into from
Nov 14, 2022
Merged

feat: authentication capabilities #369

merged 37 commits into from
Nov 14, 2022

Conversation

vobu
Copy link
Contributor

@vobu vobu commented Nov 11, 2022

authentication capabilities:

  • BTP SAP Cloud IdP
  • BTP Standard IdP
  • Office 365
  • Basic Auth
  • custom auth fields

authentication works for single browser scenarios as well as multiremote.

credentials and authentication types are provided at design-time through configuration and don't require code changes.
docs still todo, short version is:

  • standard: provide env vars wdi5_username and wdi5_password w/ respective values
  • multiremote: provide env var swdi5_$remote-id_username and wdi5_$remote-id_password w/ respective values
  • add wdi5:authentication config object (see src/types/wdi5.types.ts*Authenticator) to the capabilities section of the wdio.conf.(t|j)s file

addressing #207

Siolto and others added 20 commits November 2, 2022 10:01
- introduce authenticator .conf file
- introduce authenticator test scripts
- add first dummy btp authenticator login script
- add dotenv to load .env variables
- authenticate when wdi5_authenticate is in capabilities
- move authenticator tests to the ts-app
- add BasicAuth support and tests
- enhance BTP login
- enhance super Authenticator for multiRemote support
- introduce getter methods for username and password
- update already existing authenticators for multi remote

Co-authored-by: Volker Buzek <[email protected]>
Co-authored-by: Constantin Lebrecht <[email protected]>
to hold back on wdio8
Copy link
Collaborator

@Siolto Siolto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw error when obligatory parameters for custom auth are missing, needs to be implemented.

src/lib/authentication/CustomAuthenticator.ts Outdated Show resolved Hide resolved
@vobu vobu merged commit 9c23bda into main Nov 14, 2022
@vobu vobu deleted the feat/authenticator branch November 14, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants