Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make saveObject() work in unsecure contexts #419

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Conversation

mocsa
Copy link
Contributor

@mocsa mocsa commented Feb 4, 2023

A solution for #416 . Calculates the UUID using getRandomValues() until randomUUID() is only available in secure contexts (HTTPS and localhost).

A solution for ui5-community#416 . Calculates the UUID using getRandomValues() until randomUUID() is only available in secure contexts (HTTPS and localhost).
@vobu
Copy link
Contributor

vobu commented Feb 23, 2023

the failed tests are false-positives.
just tested this extensively locally, and thus will merge this.

@vobu vobu merged commit c293f0f into ui5-community:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants