Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rm obsolete design time artifacts #422

Merged
merged 6 commits into from
Feb 8, 2023
Merged

fix: rm obsolete design time artifacts #422

merged 6 commits into from
Feb 8, 2023

Conversation

vobu
Copy link
Contributor

@vobu vobu commented Feb 8, 2023 •
edited
Loading

  • make the constructor parameters for the service implementation itself optional
  • add late-inject test in TS scope

fixes #421

@vobu
fix: rm obsolete design time artifacts
572b481 
- constructor
- type import
@vobu vobu requested a review from Siolto February 8, 2023 13:46
@vobu vobu merged commit f9bf300 into main Feb 8, 2023
@vobu vobu deleted the fix/421 branch February 15, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siolto Siolto Awaiting requested review from Siolto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a new instance of ui5Service using TS
1 participant
@vobu