fix: timeout from config during late inject

[nair-sumesh]

No description provided.

[nair-sumesh]

Resolves Issue

[nair-sumesh]

@vobu : could you please generate the package-lock file for the rest of the test to be executed. At my end it will add internal library dependency like last time..

[vobu]

@vobu : could you please generate the package-lock file for the rest of the test to be executed. At my end it will add internal library dependency like last time..

sure, will do.
but before: could you also please add a test for verifying the caching of the wdi5 config?
I'd suggest to add a dedicated cache-config.test.ts (or similar name) to /test and test for late wdi5 injection containing the cached config

[nair-sumesh]

@vobu : could you please generate the package-lock file for the rest of the test to be executed. At my end it will add internal library dependency like last time..

sure, will do. but before: could you also please add a test for verifying the caching of the wdi5 config? I'd suggest to add a dedicated cache-config.test.ts (or similar name) to /test and test for late wdi5 injection containing the cached config

Done. let me know if this works.

[vobu]

@vobu : could you please generate the package-lock file for the rest of the test to be executed. At my end it will add internal library dependency like last time..

sure, will do. but before: could you also please add a test for verifying the caching of the wdi5 config? I'd suggest to add a dedicated cache-config.test.ts (or similar name) to /test and test for late wdi5 injection containing the cached config

Done. let me know if this works.

cool, thanks for adding the test → this safeguards the caching feature!
could you now please look into the failing tests? ignore the auth tests for now, but please peek into the failing JS- and TS-tests.
thx again!

[nair-sumesh]

feature!

Actually I am not able to execute the test. I will try again at weekend.
I installed the dependency using the script in package.json.
However, during test execution, I get the error that ui5 service module is not found.
It worked last time, but not sure what's went wrong now.

[vobu]

feature!

Actually I am not able to execute the test. I will try again at weekend. I installed the dependency using the script in package.json. However, during test execution, I get the error that ui5 service module is not found. It worked last time, but not sure what's went wrong now.

don't forget to npm run build before working on any tests 😉
(or npm run build:watch)

the JS tests seem to be fixed now - good job!
however, there's still the TS test for late injecting UI5 failing - could you please have a look again! thx!

[nair-sumesh]

should work now

[vobu]

should work now

cool, again thx!
btw: the one failing test in the auth test suite is fine IMO as it is one of the flaky ones...

now, @Siolto and @dominikfeininger - would like your review on this. We talked about caching the (wd5-) config before. Now there's a concrete use case for it. What do you think about this implementation?

[dominikfeininger]

not sure about all the global.__wdi5Config though

[Siolto]

This PR is fine for from my side. Thanks @nair-sumesh for the input!
But we should generally check again were we declare all our different wdi5 specific properties. These are currently set in different places. A uniform location would be better here

[vobu]

so we're good to go it seems!
(i'll take a look at the failing auth test due to (again) package-lock issues)